Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Font: Fix ascent/descent-override property typo #45125

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

t-hamano
Copy link
Contributor

Fix: #44919

What?

This PR fixes a typo in the ascender/descender definition of the font.

How?

I searched the repository and corrected all areas that were typos.

Testing Instructions

In TT3's theme.json, change the fontFace property as follows:

			"fontFamilies": [
				{
					"fontFace": [
						{
							"fontFamily": "DM Sans",
							"fontStretch": "normal",
							"fontStyle": "normal",
							"fontWeight": "400",
							"src": [
								"file:./assets/fonts/dm-sans/DMSans-Regular.woff2"
							],
							"ascentOverride": "300%"
						},
						{
							"fontFamily": "DM Sans",
							"fontStretch": "normal",
							"fontStyle": "italic",
							"fontWeight": "400",
							"src": [
								"file:./assets/fonts/dm-sans/DMSans-Regular-Italic.woff2"
							],
							"descentOverride": "300%"
						},
						...
					]
				}
				...
			]

In webfonts-inline-css, check that the font-face property is output correctly.

Screenshots or screencast

override

@codesandbox
Copy link

codesandbox bot commented Oct 19, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @t-hamano!

@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Oct 19, 2022
@t-hamano t-hamano merged commit ab36967 into trunk Oct 19, 2022
@t-hamano t-hamano deleted the typography-override-typo branch October 19, 2022 23:25
@github-actions github-actions bot added this to the Gutenberg 14.5 milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typography Font Family ascendOverride typo
2 participants