Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Native demo editor supports Xcode 14 #45120

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Oct 19, 2022

What?

Address a native Demo editor build error when using Xcode 14 to build to a physical device.

[...]/packages/react-native-editor/ios/Pods/Pods.xcodeproj: error: Signing for "WordPress-Aztec-iOS-WordPress-Aztec-iOS" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'WordPress-Aztec-iOS-WordPress-Aztec-iOS' from project 'Pods')
[...]/packages/react-native-editor/ios/Pods/Pods.xcodeproj: error: Signing for "React-Core-AccessibilityResources" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'React-Core-AccessibilityResources' from project 'Pods')

Why?

The native Demo editor fails to build using Xcode 14.

How?

Apply a suggested workaround for the Xcode 14 build error.

Testing Instructions

  1. Check out trunk branch.
  2. cd packages/react-native-editor/ios/
  3. rm -rf Pods/
  4. bundle exec pod install
  5. Build the native Demo editor to a physical device with Xcode 14.
  6. Note the build error occurs.
  7. Check out this PR branch.
  8. cd packages/react-native-editor/ios/
  9. rm -rf Pods/
  10. bundle exec pod install
  11. Build the native Demo editor to a physical device with Xcode 14.
  12. Verify the error does not occur.

Screenshots or screencast

n/a

@dcalhoun dcalhoun added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Build Tooling Issues or PRs related to build tooling labels Oct 19, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 19, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@dcalhoun dcalhoun added the Mobile App - Automation Label used to initiate Mobile App PR Automation label Oct 19, 2022
@dcalhoun dcalhoun marked this pull request as ready for review October 19, 2022 15:59
@geriux geriux self-requested a review October 21, 2022 12:54
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've followed the steps and now I'm able to run the demo app on my device without any issues 🚀 Nice work!

@dcalhoun dcalhoun self-assigned this Oct 25, 2022
@dcalhoun dcalhoun merged commit f890071 into trunk Oct 25, 2022
@dcalhoun dcalhoun deleted the build/native-demo-editor-supports-xcode-14 branch October 25, 2022 14:10
@github-actions github-actions bot added this to the Gutenberg 14.5 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants