Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storybook intro #45115

Merged
merged 6 commits into from
Oct 20, 2022
Merged

Add storybook intro #45115

merged 6 commits into from
Oct 20, 2022

Conversation

bph
Copy link
Contributor

@bph bph commented Oct 19, 2022

fixes #45080

What?

Updates the Introduction on the Storybook site

Why?

It needs more information than Hello World

How?

Create the page in markdown >

Testing Instructions

Screenshots or screencast

Screen Shot 2022-10-19 at 09 31 52

Props @juanmaguitar @mburridge @mirka for review of the content.

@bph bph added the Storybook Storybook and its stories for components label Oct 19, 2022
@bph bph requested review from mirka and ciampo October 19, 2022 13:34
@bph bph self-assigned this Oct 19, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 19, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@bph bph requested a review from ciampo October 19, 2022 13:58
@ciampo ciampo added the [Type] Developer Documentation Documentation for developers label Oct 19, 2022
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bph for your work 🚀

e2e tests seem to be broken, we will be able to merge as soon as the situation gets sorted out

@bph
Copy link
Contributor Author

bph commented Oct 19, 2022

@ciampo Thank you so much for your assistance and approval.
Although, I have no idea about those tests, please let me know what I can do to push it over the finish line.

@ciampo ciampo force-pushed the add-storybook-intro branch from def85c2 to ddcdf4d Compare October 20, 2022 08:46
@ciampo
Copy link
Contributor

ciampo commented Oct 20, 2022

No worries! The failing tests are unrelated, so there isn't much we can do apart from rebasing and hoping that the tests were fixed on trunk in the meantime 🤷 (which I've just done)

@ciampo ciampo force-pushed the add-storybook-intro branch from ddcdf4d to 5b3709f Compare October 20, 2022 12:04
@ciampo ciampo merged commit d478ff1 into trunk Oct 20, 2022
@ciampo ciampo deleted the add-storybook-intro branch October 20, 2022 12:54
@github-actions github-actions bot added this to the Gutenberg 14.5 milestone Oct 20, 2022
@ciampo
Copy link
Contributor

ciampo commented Oct 20, 2022

Merged as failing native e2e tests are not related to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Storybook - Introduction page
2 participants