[Block Library - Audio]: Add toolbar button to add/remove caption #45112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Package] Block library
ntsekouras
requested review from
mcsf,
Mamaduka,
jameskoster,
jasmussen and
alexstine
|
|
|
Size Change: +192 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
ntsekouras
changed the title
alexstine
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Thanks @ntsekouras . Looks good.
On a side note, it is quite disturbing how inaccessible the audio block is. It would be cool to get some work done on it. Focus loss makes it nearly impossible to test with the keyboard.
Mamaduka
reviewed
Oct 19, 2022
Mamaduka
reviewed
Oct 19, 2022
ntsekouras
force-pushed
the
add/caption-toolbar-button-audio-block
branch
from
ceb9b3c to
146d1cd
Compare
|
Thank you, this is such a better experience. |
This was referenced Feb 4, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a toggle toolbar item on Audio's Block Toolbar to add/remove a caption. It follows suit with what we did in Image block with the a11y concerns addressed.
Testing Instructions
Screenshots or screencast
Screen.Recording.2022-10-19.at.3.30.54.PM.mov