Components: Refactor withFocusReturn tests to RTL
#45012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
tyxla
requested review from
Mamaduka,
mirka,
jsnajdr,
ciampo,
chad1008 and
ntsekouras
30 tasks
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
tyxla
force-pushed
the
refactor/with-focus-return-rtl
branch
from
4f35506 to
d9daf50
Compare
Sure thing! Actually, the |
|
Thanks again, @tyxla! |
Focusing the |
This actually makes a lot of sense and I agree with the sentiment. In that case, we'll need I've changed it in 24b2f4e to actually resemble a user click on the textarea, which consequently focuses it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR refactors the
withFocusReturntests to fully use@testing-library/reactinstead ofreact-test-renderer.Part of #44780.
Why?
It is a part of the recent effort to use
@testing-library/reactas the primary testing library.How?
We're updating rendering to now be with RTL.
Testing Instructions
Verify tests still pass:
npm run test:unit packages/components/src/higher-order/with-focus-return/test/index.js