Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark "post author name" as stable / no longer experimental #45008

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Mark "post author name" as stable / no longer experimental #45008

merged 1 commit into from
Jan 20, 2023

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 17, 2022 •
edited
Loading

What?

Removes the "__experimental": true, from block.json.

Closes #44618

Why?

From WP 6.2, the block should be included in WP core and not be experimental.

How?

Removes the "__experimental": true, from block.json.

@carolinan carolinan marked this pull request as ready for review October 17, 2022 08:32
@carolinan carolinan requested a review from ajitbohra as a code owner October 17, 2022 08:32
@desrosj desrosj mentioned this pull request Nov 9, 2022
Closed
@skorasaurus skorasaurus added the [Block] Post Author Affects the Post Author Block label Nov 14, 2022
jorgefilipecosta
jorgefilipecosta approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ntsekouras ntsekouras force-pushed the update/post-author-name branch from ebabae0 to a156ce3 Compare January 20, 2023 12:37
ntsekouras
ntsekouras approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carolina! I rebased to make the CI run again.

@ntsekouras ntsekouras enabled auto-merge (squash) January 20, 2023 12:38
@ntsekouras ntsekouras merged commit f2ce48f into trunk Jan 20, 2023
@ntsekouras ntsekouras deleted the update/post-author-name branch January 20, 2023 13:08
@github-actions github-actions bot added this to the Gutenberg 15.1 milestone Jan 20, 2023
@github-actions
Copy link

Flaky tests detected in a156ce3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3967682431
📝 Reported issues:

@juanmaguitar juanmaguitar added [Type] Enhancement A suggestion for improvement. [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Enhancement A suggestion for improvement. labels Feb 1, 2023
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Feb 8, 2023
@femkreations femkreations mentioned this pull request Mar 1, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Post Author Affects the Post Author Block Needs User Documentation Needs new user documentation [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 15.1
Development

Successfully merging this pull request may close these issues.

Missing core/post-author-name in WP Core
6 participants
@carolinan @jorgefilipecosta @ntsekouras @juanmaguitar @skorasaurus @femkreations