Block Popover: Fix incorrect positioning of padding and margin visualizers on scroll #44998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izers on scroll. Adds a shift prop to tell whether the floating UI should shift into view or stay absolutely positioned.
…nd margin visualizers.
|
Size Change: +120 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
This tested well for me. The new prop should probably be added to the component readme. |
Good idea! I can do that later today, or sometime tomorrow. |
|
Should be good to go now, just need a review to approve. |
glendaviesnz
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44977.
What?
Adds a shift prop to tell whether the floating UI should shift into view or stay positioned normally.
Why?
This fixes a visual bug where if you scroll past the top of a group and use padding or margin, the visualizer appears always at the top of the page. This is due to the Floating UI library's shift property.
How?
Adds a shift prop to BlockPopover that defaults to true, as that was always the value for the component. Padding and Margin Visualizers pass false to the shift property so that Floating UI library does not put the padding and margin visualizers at the top of the screen even when scrolling past element.
Testing Instructions
Screenshots or screencast