Global Styles: Invoke zoomed-out view when selecting a style variation #44987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +60 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Oct 17, 2022
| } | ||
| }, [ mode ] ); | ||
|
|
||
| // Intentionality left withou any dependency. |
There was a problem hiding this comment.
There are a few typos in this comment.
oandregal
reviewed
Oct 17, 2022
| @@ -120,6 +129,31 @@ function ScreenStyleVariations() { | |||
| ]; | |||
| }, [ variations ] ); | |||
|
|
|||
| const { __unstableSetEditorMode } = useDispatch( blockEditorStore ); | |||
| const shouldRevertInitialMode = useRef( null ); | |||
| useEffect( () => { | |||
There was a problem hiding this comment.
We're tracking mode changes to decide whether to revert to the initial mode or not. If the user has done any mode changes since the style variations were opened, we won't revert to the initial.
So, in a situation like this:
- user starts in edit mode
- goes to style variations, so the editor is switched automatically to zoom-out mode
- user intentionally switches off zoom-out mode (goes back to edit)
- user intentionally switches on zoom-out mode
- user closes global styles sidebar
What's the expected mode at this point?
With this PR, the mode stays in zoom-out. I think it makes sense because trying to be too smart may be too intrusive. Though, I see how switching off zoom-out mode can be something people do if they want more focus for a specific change, and then going back to the zoom-out. In that flow, staying in zoom-out after closing style variations may be weird.
There was a problem hiding this comment.
I opted for this approach because it was the most simple code and seemed to fit most use cases. If you prefer, I can try an approach where if the end mode is still zoom-out we always revert to the initial mode.
oandregal
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
There are some typos in the comments.
I've also left a comment on how we decide whether to change to initial mode for future reviewers https://github.com/WordPress/gutenberg/pull/44987/files#r997236444
oandregal
added
the
[Feature] Site Editor
jorgefilipecosta
force-pushed
the
update/global-styles-invoke-zoomed-out-view-when-selecting-a-style-variation
branch
from
277ed25 to
05f37df
Compare
jorgefilipecosta
deleted the
update/global-styles-invoke-zoomed-out-view-when-selecting-a-style-variation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #44419
This PR opens the zoom-out when the user selects a style variation.
Testing