Migrate nonce.test.js to Playwright
#44929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Thanks, @kevin940726!
The solution here makes sense to me and is more reliable than waiting 5 seconds in tests.
The fact that nonces expire in the time specified by the filter probably already has a test case in PHPUnit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An alternative to #44069. It's more tricky than I thought, so I decided to open another PR for a clearer explanation.
c.c. @pooja-muchandikar
Why?
The original Puppeteer nonce test relies on the
noncetest plugin to automatically expire the login nonce every 5 seconds. It works in the old Jest/Puppeteer framework because we only ran one test at a time and we didn't reuse the authentication state. However, in Playwright we usestorageStateto reuse the same authentication state to speed up the process. This makes testing nonce the old way more painful and error-prone.How?
The solution is to use
page.route()to mock the API and return a fake expiration response. This allows us to avoid the 5-second timeout in our test and we can remove the test plugin entirely. This also means that we can run this test in parallel if needed in the future.Testing Instructions
CI should pass.