Fix list to paragraph transform #4460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed a bug
I believe the children are not always an array. |
|
Whoops, looks like I corrected it in one place but not the other. :) |
ellatrix
force-pushed
the
fix/list-paragraph-transform
branch
from
c831336 to
59063fb
Compare
|
It's kind of messy when having to take prettier into account too. :/ |
3 tasks
| listContent.forEach( ( content, index ) => { | ||
| if ( content.type === 'ol' || content.type === 'ul' ) { | ||
| acc.push( ...listItemsToArray( castArray( get( content, 'props.children', [] ) ) ) ); | ||
| acc.push( [] ); |
There was a problem hiding this comment.
Is acc.push( [] ); required to have line breaks? maybe we specify in a comment the reason it is needed.
| * @return {Array} Array of Editable value arrays. | ||
| */ | ||
| function listItemsToArray( items ) { | ||
| return items.reduce( ( acc, item ) => { |
There was a problem hiding this comment.
I'm not totally certain but it looks like we may be able to use flatMap here and it has some performance advantages according to @aduth test cases. It may also simplify the code :)
tofumatt
reviewed
Jul 5, 2018
| acc.push( ...listItemsToArray( castArray( get( content, 'props.children', [] ) ) ) ); | ||
| acc.push( [] ); | ||
| } else { | ||
| // No line breaks form prettier. |
There was a problem hiding this comment.
What does this comment mean? Should it be "from Prettier"? 🤷♂️
|
Is this PR still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently nested lists fail to transform to paragraphs. This PR aims to fix that.
How Has This Been Tested?
Create list with indented items. Convert to paragraphs or quote.