Remove unnecessary background color on placeholders #44497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -8 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
I think we need this one. The backdrop filter has to have some inkling of a background color in order to function, to solve this case:
That's a Cover with a background, and then an Image placeholder inside. I wonder if #44215 (comment) is related? 🤔 |
|
Are you sure? It seems to work ok:
That's what lead me here. The issue in your PR looks like it might be caused by the white background applied to placeholders. But I can't reproduce to inspect further. |
|
Oh, I remembered incorrectly. Indeed the backdrop filter does work.
I could've sworn the color was needed for duotone, but that works too. So I'm happy to go full transparent!
However I'm still seeing the rendering glitch. Observe this craziness:
It looks like the backdrop filter is at fault here, because it's not happening to Featured Image, because apparently that doesn't yet have the backdrop filter. Since we're using a pseudo element with currentColor, we can potentially revisit this now and look for an alternative to the blur. What do you think? |
|
Wow, that is strange. If you don't mind shall we look into that separately? Removing the backdrop-filter alone probably won't be adequate:
We may also need to adjust the opacity, or even try some different effects. |
jasmussen
approved these changes
Sep 27, 2022
|
yes, something to look at! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subtle one, addressing a detail I missed in #44190.
Placeholders effectively have two backgrounds applied at the moment, a semi-transparent white one, and a semi-transparent
currentColorone. We don't need both. This PR removes the white one.Before
After