[experiments] Add README.md and CHANGELOG.md #44457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use the correct name in package.json
adamziel
added
[Type] Enhancement
|
Size Change: +305 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Sep 26, 2022
There was a problem hiding this comment.
I see that there is also .npmrc included with all packages:
https://github.com/WordPress/gutenberg/blob/trunk/packages/dom/.npmrc
As a follow-up, we could enable TS types, example:
https://github.com/WordPress/gutenberg/blob/trunk/packages/dom/tsconfig.json
|
The list of tasks necessary for a new package has grown over time 😅
Yes, it isn't that useful outside of WordPress core with all the names of packages hardcoded. We can add a bolded paragraph that emphasizes that it's for use in WP core only. |
Co-authored-by: Greg Ziółkowski <[email protected]>
Co-authored-by: Greg Ziółkowski <[email protected]>
Co-authored-by: Greg Ziółkowski <[email protected]>
gziolo
approved these changes
Sep 26, 2022
Co-authored-by: Peter Wilson <[email protected]>
Co-authored-by: Peter Wilson <[email protected]>
peterwilsoncc
approved these changes
Sep 26, 2022
|
React Native E2E failures are in line with a those I see on another PR at https://github.com/WordPress/gutenberg/actions/runs/3131829717/jobs/5083554699 – must be GitHub CI acting up. Let's get this one merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #43386 that introduced a new
@wordpresspackage calledexperiments.As @gziolo mentioned:
This PR does just that. My one concern is that it explains an intentionally opaque system, even if most non-core developers are not aware of the README.md file. I removed the consent string from the README file to avoid producing code snippets that can be copied and pasted.
Testing Instructions
Read the PR and confirm it looks good and makes sense.
CC @gziolo @jsnajdr @peterwilsoncc