Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing filter documentation #44342

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

johnbillion
Copy link
Member

What?

This is a duplicate filter that's missing its relevant inline doc.

Why?

Without this, the parser for the developer site sees this filter twice, once with its documentation and once without.

pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Sep 21, 2022
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Sep 21, 2022
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Sep 21, 2022
@michalczaplinski
Copy link
Contributor

michalczaplinski commented Sep 21, 2022

Hi @johnbillion! 👋

I'm a bit confused as to why this is necessary. As far as I understand packages/block-library/src/comments/index.php (the file that you edited) is copied over to WordPress core during the backport and package sync. After that it ends up in wp-includes/blocks/comments.php:

So, as far as I can tell, removing it in WordPress Core and adding it in Gutenberg is going to work until the next WordPress release at which point that same file is going to be copied over from Gutenberg to Core again (including that comment).

I'm also puzzled as to why how this comment present in Core but absent in Gutenberg in the first place if the comments/index.php is supposed to be just copied over verbatim 🤔 .

@johnbillion
Copy link
Member Author

@michalczaplinski The comment doesn't exist in WordPress core, it got added accidentally in WordPress/wordpress-develop@1af2c8b and reverted in WordPress/wordpress-develop@4a3d6ff in favour of making the change here which will allow it to get correctly copied into core.

@michalczaplinski
Copy link
Contributor

Got it - that makes sense now! 😃

ootwch pushed a commit to ootwch/wordpress-develop that referenced this pull request Nov 4, 2022
@aristath aristath merged commit e9d9199 into trunk Mar 21, 2023
@aristath aristath deleted the apply-filters-block_type_metadata branch March 21, 2023 07:52
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 21, 2023
@ryanwelcher ryanwelcher added [Type] Developer Documentation Documentation for developers [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants