-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a missing filter documentation #44342
Conversation
…rg repo. See WordPress/gutenberg#44342 See #55646 git-svn-id: https://develop.svn.wordpress.org/trunk@54285 602fd350-edb4-49c9-b593-d223f7449a82
…rg repo. See WordPress/gutenberg#44342 See #55646 Built from https://develop.svn.wordpress.org/trunk@54285 git-svn-id: http://core.svn.wordpress.org/trunk@53844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…rg repo. See WordPress/gutenberg#44342 See #55646 Built from https://develop.svn.wordpress.org/trunk@54285 git-svn-id: https://core.svn.wordpress.org/trunk@53844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Hi @johnbillion! 👋 I'm a bit confused as to why this is necessary. As far as I understand So, as far as I can tell, removing it in WordPress Core and adding it in Gutenberg is going to work until the next WordPress release at which point that same file is going to be copied over from Gutenberg to Core again (including that comment). I'm also puzzled as to why how this comment present in Core but absent in Gutenberg in the first place if the |
@michalczaplinski The comment doesn't exist in WordPress core, it got added accidentally in WordPress/wordpress-develop@1af2c8b and reverted in WordPress/wordpress-develop@4a3d6ff in favour of making the change here which will allow it to get correctly copied into core. |
Got it - that makes sense now! 😃 |
…rg repo. See WordPress/gutenberg#44342 See #55646 git-svn-id: https://develop.svn.wordpress.org/trunk@54285 602fd350-edb4-49c9-b593-d223f7449a82
What?
This is a duplicate filter that's missing its relevant inline doc.
Why?
Without this, the parser for the developer site sees this filter twice, once with its documentation and once without.