Try generating styles for classic themes by filtering theme.json data
#44268
Conversation
There was a problem hiding this comment.
Very cool idea, thanks for opening this up @oandregal! I can imagine it being really useful for if and when we need a different output for classic versus blocks-based themes.
I think the problem this abstraction solves might be slightly tangential to the problem of outputting the styles in #43981 at the desired level of specificity for Classic themes, though. Unless I'm missing something, I think the idea is for the base Buttons styling rules to be effectively the same in Classic and blocks themes?
| $new_data = array( | ||
| 'version' => 2, | ||
| 'settings' => array( /* we should maintain the presets by core */ ), | ||
| 'styles' => array( /* clear this? add only the base-layout-styles? */ ), |
There was a problem hiding this comment.
As a bit of background, the subtlety behind base-layout-styles is that it only outputs layout styles and skips calling get_block_classes. The logic is around here: https://github.com/WordPress/gutenberg/blob/trunk/lib/compat/wordpress-6.1/class-wp-theme-json-6-1.php#L679-L681
So it's slightly different to filtering the styles object.
That said, the original reason for base-layout-styles was to ensure that we can output base / root layout styles for things like the gap between Buttons, without pulling in / outputting styles from the styles object. Given that #43981 is proposing outputting styles for classic themes, too, then the concept of base-layout-styles might become redundant anyway 🙂
oandregal
force-pushed
the
try/theme-json-for-classic-themes
branch
from
a607975 to
5c019f0
Compare
| @@ -47,6 +47,10 @@ public function update_with( $new_data ) { | |||
| return $this; | |||
| } | |||
|
|
|||
| public function create_with( $new_data ) { | |||
There was a problem hiding this comment.
Turns out we don't have a great way to clear existing data through the merge process if it's not overwrite it. This creates a new object from scratch. May need to revisit the ability to clear data but this works for now.
| * We should be able to remove this. | ||
| * Without it, it breaks. | ||
| */ | ||
| "spacing" => array( |
There was a problem hiding this comment.
Something breaks if I create a WP_Theme_JSON object without settings. It seems that it's this bit that fails. I haven't been able to look at why, but it should be possible to create an object with empty settings, correct? cc @glendaviesnz
|
I'm gardening my PRs and this one doesn't seem to have gotten any momentum. Closing for now, can reopen later if necessary. |
What?
Potential alternative to #43981
This PR experiments with extracting the logic we have for classic themes to a different place, making use of the new
theme_json_(origin)filters.Why?
It's increasingly difficult to reason about and follow which styles would classic themes get.
How?
By making use of the
theme_json_(origin)filters we can modify thetheme.jsonif, and only if, the current theme in use is a classic theme.Testing Instructions
Not ready for testing. It's just a skeleton so far.