Create Block: Update templates to use APIs introduced in WP 6.1 #44185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Enhancement
gziolo
added
the
Developer Experience
gziolo
force-pushed
the
update/create-block-wp-6.1
branch
from
1325666 to
8981340
Compare
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/create-block-wp-6.1
branch
from
8981340 to
6b8f53a
Compare
gziolo
commented
Sep 15, 2022
Comment on lines
75
to
77
| 'editor_script' => '{{namespace}}-{{slug}}-block-editor', | ||
| 'editor_style' => '{{namespace}}-{{slug}}-block-editor', | ||
| 'style' => '{{namespace}}-{{slug}}-block', |
There was a problem hiding this comment.
For now, I had to leave it as is, but I hope we can figure out a way to move all JS and CSS registration to block.json when someone opts out from using build tools. Tracked in #40447.
gziolo
commented
Sep 15, 2022
| @@ -33,53 +33,6 @@ | |||
| * @see https://developer.wordpress.org/block-editor/reference-guides/block-api/block-registration/ | |||
| */ | |||
| registerBlockType( '{{namespace}}/{{slug}}', { | |||
| /** | |||
There was a problem hiding this comment.
The removed code is loading from block.json now.
gziolo
force-pushed
the
update/create-block-wp-6.1
branch
from
a9e3ae8 to
843960b
Compare
bph
added
the
Needs Dev Note
gziolo
force-pushed
the
update/create-block-wp-6.1
branch
from
843960b to
2fea1ad
Compare
ryanwelcher
approved these changes
Oct 3, 2022
gziolo
force-pushed
the
update/create-block-wp-6.1
branch
from
2fea1ad to
c7be5ea
Compare
|
Included changes to the documentation with c7be5ea that reflect the most recent fix in WordPress core: https://core.trac.wordpress.org/changeset/54367. |
|
@ryanwelcher , could you please resolve the conflicts of this PR so we can land it? Thank you! |
|
@c4rl0sbr4v0 I've updated the PR. There is a change to a dependabot.yml file that I am not sure is supposed to be there though. Maybe I should revert that file? |
|
Thank you! |
|
Thank you for bringing it up to date. It should be good to land in a few days so it gets published to npm on Nov 2nd - one day after WP 6.1 is out. It feels like a perfect timing with Gutenberg releases 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Now that we have support for
renderinblock.jsoncoming to WordPress 6.1, we can integrate that into@wordpress/create-blockto improve the developer experience.This PR will have to wait to land until we get closer to the WordPress 6.1 release date (November 1st).
How?
Add a new
renderfield todefaultValuesin external templates to let folks define the path to the PHP file that's going to be used with dynamic blocks. I also updated all dynamic variants to use his newly introduced config option.Testing Instructions
The following should scaffold a dynamic block that works without the build step.
This is how you can test the version with the build step for the tutorial in Block Editor Handbook:
npx wp-create-block --no-wp-scripts --variant dynamic --template @wordpress/create-block-tutorial-template dynamic-example-tutorial cd dynamic-example-tutorial ../node_modules/.bin/wp-scripts build