-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes code typo that causes content to be off center in some themes. #44179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
tellthemachines
and removed request for
ellatrix
September 15, 2022 07:47
draganescu
added
[Type] Bug
An existing feature does not function as intended
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
[Package] Style Engine
/packages/style-engine
Backport to Gutenberg Minor Release
Pull request that needs to be backported to a Gutenberg minor release
labels
Sep 15, 2022
MaggieCabrera
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great detective skills, thanks!
Size Change: -2 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
cbravobernal
pushed a commit
that referenced
this pull request
Sep 15, 2022
cbravobernal
removed
the
Backport to Gutenberg Minor Release
Pull request that needs to be backported to a Gutenberg minor release
label
Sep 15, 2022
Thanks so much for this! |
ockham
pushed a commit
that referenced
this pull request
Sep 19, 2022
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: ddd1ed0 |
ockham
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Style Engine
/packages/style-engine
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a code typo
here
which caused content to not be centered when it had a fixed width.
Why?
Because it's a bug.
How?
Find typo. Fix typo.
Testing Instructions
This rule:
.editor-styles-wrapper .block-editor-block-list__layout.is-root-container > :where(:not(.alignleft):not(.alignright):not(.alignfull))
should not contain
margin-right: auto !importantt;
(notice the extra t).Screenshots or screencast
N/A