Spacing presets: fix bug with unlinked not applying if non int slugs used #44136

glendaviesnz · 2022-09-13T22:05:44Z

What?

Removes the check for digits from the check to see it spacing values are set and just checks for a defined value

Why?

Fixes: #44133 - if a theme uses string only slugs for spacing sizes the link/unlink option doesn't work as expected - control shows linked when returning to block even if unlinked values are set

How?

Removes the regex check for \d

Testing Instructions

In a theme add the following to the theme.json settings.spacing section:

"spacing": {
	"spacingScale": {
		"steps": 0
	},
	"spacingSizes": [
		{
			"name": "XS",
			"size": "0.5rem",
			"slug": "x-small"
		},
		{
			"name": "Small",
			"size": "1rem",
			"slug": "small"
		},
		{
			"name": "Medium",
			"size": "1.5rem",
			"slug": "medium"
		},
		{
			"name": "Large",
			"size": "clamp(1.5rem, 1.364vw + 1.159rem, 2.25rem)",
			"slug": "large"
		},
		{
			"name": "XL",
			"size": "clamp(2.25rem, 1.364vw + 1.909rem, 3rem)",
			"slug": "x-large"
		},
		{
			"name": "2XL",
			"size": "clamp(3rem, 3.603vw + 2.091rem, 5rem)",
			"slug": "xx-large"
		},
		{
			"name": "3XL",
			"size": "clamp(5rem, 3.636vw + 4.091rem, 7rem)",
			"slug": "xxx-large"
		}
	]
}

Add a paragraph block and set different spacing for each side
Unfocus and refocus the block and check that the padding control shows unlinked

Screenshots or screencast

Before:

linked-before.mp4

After:

linked-after.mp4

…tandard 10,20,30 slugs

github-actions · 2022-09-13T22:14:13Z

Size Change: -10 B (0%)

Total Size: 1.25 MB

Filename	Size	Change
`build/block-editor/index.min.js`	163 kB	-10 B (0%)

ℹ️ View Unchanged

Filename	Size
`build/a11y/index.min.js`	982 B
`build/annotations/index.min.js`	2.76 kB
`build/api-fetch/index.min.js`	2.26 kB
`build/autop/index.min.js`	2.14 kB
`build/blob/index.min.js`	475 B
`build/block-directory/index.min.js`	7.05 kB
`build/block-directory/style-rtl.css`	990 B
`build/block-directory/style.css`	991 B
`build/block-editor/default-editor-styles-rtl.css`	378 B
`build/block-editor/default-editor-styles.css`	378 B
`build/block-editor/style-rtl.css`	15.3 kB
`build/block-editor/style.css`	15.3 kB
`build/block-library/blocks/archives/editor-rtl.css`	61 B
`build/block-library/blocks/archives/editor.css`	60 B
`build/block-library/blocks/archives/style-rtl.css`	65 B
`build/block-library/blocks/archives/style.css`	65 B
`build/block-library/blocks/audio/editor-rtl.css`	150 B
`build/block-library/blocks/audio/editor.css`	150 B
`build/block-library/blocks/audio/style-rtl.css`	122 B
`build/block-library/blocks/audio/style.css`	122 B
`build/block-library/blocks/audio/theme-rtl.css`	126 B
`build/block-library/blocks/audio/theme.css`	126 B
`build/block-library/blocks/avatar/editor-rtl.css`	116 B
`build/block-library/blocks/avatar/editor.css`	116 B
`build/block-library/blocks/avatar/style-rtl.css`	84 B
`build/block-library/blocks/avatar/style.css`	84 B
`build/block-library/blocks/block/editor-rtl.css`	161 B
`build/block-library/blocks/block/editor.css`	161 B
`build/block-library/blocks/button/editor-rtl.css`	482 B
`build/block-library/blocks/button/editor.css`	482 B
`build/block-library/blocks/button/style-rtl.css`	523 B
`build/block-library/blocks/button/style.css`	523 B
`build/block-library/blocks/buttons/editor-rtl.css`	337 B
`build/block-library/blocks/buttons/editor.css`	337 B
`build/block-library/blocks/buttons/style-rtl.css`	332 B
`build/block-library/blocks/buttons/style.css`	332 B
`build/block-library/blocks/calendar/style-rtl.css`	207 B
`build/block-library/blocks/calendar/style.css`	207 B
`build/block-library/blocks/categories/editor-rtl.css`	84 B
`build/block-library/blocks/categories/editor.css`	83 B
`build/block-library/blocks/categories/style-rtl.css`	100 B
`build/block-library/blocks/categories/style.css`	100 B
`build/block-library/blocks/code/editor-rtl.css`	53 B
`build/block-library/blocks/code/editor.css`	53 B
`build/block-library/blocks/code/style-rtl.css`	103 B
`build/block-library/blocks/code/style.css`	103 B
`build/block-library/blocks/code/theme-rtl.css`	124 B
`build/block-library/blocks/code/theme.css`	124 B
`build/block-library/blocks/columns/editor-rtl.css`	108 B
`build/block-library/blocks/columns/editor.css`	108 B
`build/block-library/blocks/columns/style-rtl.css`	406 B
`build/block-library/blocks/columns/style.css`	406 B
`build/block-library/blocks/comment-author-avatar/editor-rtl.css`	125 B
`build/block-library/blocks/comment-author-avatar/editor.css`	125 B
`build/block-library/blocks/comment-content/style-rtl.css`	92 B
`build/block-library/blocks/comment-content/style.css`	92 B
`build/block-library/blocks/comment-template/style-rtl.css`	187 B
`build/block-library/blocks/comment-template/style.css`	185 B
`build/block-library/blocks/comments-pagination-numbers/editor-rtl.css`	123 B
`build/block-library/blocks/comments-pagination-numbers/editor.css`	121 B
`build/block-library/blocks/comments-pagination/editor-rtl.css`	222 B
`build/block-library/blocks/comments-pagination/editor.css`	209 B
`build/block-library/blocks/comments-pagination/style-rtl.css`	235 B
`build/block-library/blocks/comments-pagination/style.css`	231 B
`build/block-library/blocks/comments-title/editor-rtl.css`	75 B
`build/block-library/blocks/comments-title/editor.css`	75 B
`build/block-library/blocks/comments/editor-rtl.css`	834 B
`build/block-library/blocks/comments/editor.css`	832 B
`build/block-library/blocks/comments/style-rtl.css`	632 B
`build/block-library/blocks/comments/style.css`	630 B
`build/block-library/blocks/cover/editor-rtl.css`	605 B
`build/block-library/blocks/cover/editor.css`	607 B
`build/block-library/blocks/cover/style-rtl.css`	1.57 kB
`build/block-library/blocks/cover/style.css`	1.55 kB
`build/block-library/blocks/embed/editor-rtl.css`	293 B
`build/block-library/blocks/embed/editor.css`	293 B
`build/block-library/blocks/embed/style-rtl.css`	410 B
`build/block-library/blocks/embed/style.css`	410 B
`build/block-library/blocks/embed/theme-rtl.css`	126 B
`build/block-library/blocks/embed/theme.css`	126 B
`build/block-library/blocks/file/editor-rtl.css`	300 B
`build/block-library/blocks/file/editor.css`	300 B
`build/block-library/blocks/file/style-rtl.css`	253 B
`build/block-library/blocks/file/style.css`	254 B
`build/block-library/blocks/file/view.min.js`	346 B
`build/block-library/blocks/freeform/editor-rtl.css`	2.44 kB
`build/block-library/blocks/freeform/editor.css`	2.44 kB
`build/block-library/blocks/gallery/editor-rtl.css`	948 B
`build/block-library/blocks/gallery/editor.css`	950 B
`build/block-library/blocks/gallery/style-rtl.css`	1.53 kB
`build/block-library/blocks/gallery/style.css`	1.53 kB
`build/block-library/blocks/gallery/theme-rtl.css`	108 B
`build/block-library/blocks/gallery/theme.css`	108 B
`build/block-library/blocks/group/editor-rtl.css`	337 B
`build/block-library/blocks/group/editor.css`	337 B
`build/block-library/blocks/group/style-rtl.css`	57 B
`build/block-library/blocks/group/style.css`	57 B
`build/block-library/blocks/group/theme-rtl.css`	78 B
`build/block-library/blocks/group/theme.css`	78 B
`build/block-library/blocks/heading/style-rtl.css`	76 B
`build/block-library/blocks/heading/style.css`	76 B
`build/block-library/blocks/html/editor-rtl.css`	327 B
`build/block-library/blocks/html/editor.css`	329 B
`build/block-library/blocks/image/editor-rtl.css`	876 B
`build/block-library/blocks/image/editor.css`	873 B
`build/block-library/blocks/image/style-rtl.css`	627 B
`build/block-library/blocks/image/style.css`	630 B
`build/block-library/blocks/image/theme-rtl.css`	126 B
`build/block-library/blocks/image/theme.css`	126 B
`build/block-library/blocks/latest-comments/style-rtl.css`	284 B
`build/block-library/blocks/latest-comments/style.css`	284 B
`build/block-library/blocks/latest-posts/editor-rtl.css`	213 B
`build/block-library/blocks/latest-posts/editor.css`	212 B
`build/block-library/blocks/latest-posts/style-rtl.css`	463 B
`build/block-library/blocks/latest-posts/style.css`	462 B
`build/block-library/blocks/list/style-rtl.css`	88 B
`build/block-library/blocks/list/style.css`	88 B
`build/block-library/blocks/media-text/editor-rtl.css`	266 B
`build/block-library/blocks/media-text/editor.css`	263 B
`build/block-library/blocks/media-text/style-rtl.css`	507 B
`build/block-library/blocks/media-text/style.css`	505 B
`build/block-library/blocks/more/editor-rtl.css`	431 B
`build/block-library/blocks/more/editor.css`	431 B
`build/block-library/blocks/navigation-link/editor-rtl.css`	705 B
`build/block-library/blocks/navigation-link/editor.css`	703 B
`build/block-library/blocks/navigation-link/style-rtl.css`	115 B
`build/block-library/blocks/navigation-link/style.css`	115 B
`build/block-library/blocks/navigation-submenu/editor-rtl.css`	296 B
`build/block-library/blocks/navigation-submenu/editor.css`	295 B
`build/block-library/blocks/navigation-submenu/view.min.js`	423 B
`build/block-library/blocks/navigation/editor-rtl.css`	1.99 kB
`build/block-library/blocks/navigation/editor.css`	2 kB
`build/block-library/blocks/navigation/style-rtl.css`	2.17 kB
`build/block-library/blocks/navigation/style.css`	2.16 kB
`build/block-library/blocks/navigation/view-modal.min.js`	2.78 kB
`build/block-library/blocks/navigation/view.min.js`	443 B
`build/block-library/blocks/nextpage/editor-rtl.css`	395 B
`build/block-library/blocks/nextpage/editor.css`	395 B
`build/block-library/blocks/page-list/editor-rtl.css`	363 B
`build/block-library/blocks/page-list/editor.css`	363 B
`build/block-library/blocks/page-list/style-rtl.css`	175 B
`build/block-library/blocks/page-list/style.css`	175 B
`build/block-library/blocks/paragraph/editor-rtl.css`	174 B
`build/block-library/blocks/paragraph/editor.css`	174 B
`build/block-library/blocks/paragraph/style-rtl.css`	260 B
`build/block-library/blocks/paragraph/style.css`	260 B
`build/block-library/blocks/post-author/style-rtl.css`	175 B
`build/block-library/blocks/post-author/style.css`	176 B
`build/block-library/blocks/post-comments-form/editor-rtl.css`	96 B
`build/block-library/blocks/post-comments-form/editor.css`	96 B
`build/block-library/blocks/post-comments-form/style-rtl.css`	493 B
`build/block-library/blocks/post-comments-form/style.css`	493 B
`build/block-library/blocks/post-date/style-rtl.css`	61 B
`build/block-library/blocks/post-date/style.css`	61 B
`build/block-library/blocks/post-excerpt/editor-rtl.css`	73 B
`build/block-library/blocks/post-excerpt/editor.css`	73 B
`build/block-library/blocks/post-excerpt/style-rtl.css`	69 B
`build/block-library/blocks/post-excerpt/style.css`	69 B
`build/block-library/blocks/post-featured-image/editor-rtl.css`	547 B
`build/block-library/blocks/post-featured-image/editor.css`	545 B
`build/block-library/blocks/post-featured-image/style-rtl.css`	315 B
`build/block-library/blocks/post-featured-image/style.css`	315 B
`build/block-library/blocks/post-template/editor-rtl.css`	99 B
`build/block-library/blocks/post-template/editor.css`	98 B
`build/block-library/blocks/post-template/style-rtl.css`	282 B
`build/block-library/blocks/post-template/style.css`	282 B
`build/block-library/blocks/post-terms/style-rtl.css`	73 B
`build/block-library/blocks/post-terms/style.css`	73 B
`build/block-library/blocks/post-title/style-rtl.css`	100 B
`build/block-library/blocks/post-title/style.css`	100 B
`build/block-library/blocks/preformatted/style-rtl.css`	103 B
`build/block-library/blocks/preformatted/style.css`	103 B
`build/block-library/blocks/pullquote/editor-rtl.css`	135 B
`build/block-library/blocks/pullquote/editor.css`	135 B
`build/block-library/blocks/pullquote/style-rtl.css`	326 B
`build/block-library/blocks/pullquote/style.css`	325 B
`build/block-library/blocks/pullquote/theme-rtl.css`	167 B
`build/block-library/blocks/pullquote/theme.css`	167 B
`build/block-library/blocks/query-pagination-numbers/editor-rtl.css`	122 B
`build/block-library/blocks/query-pagination-numbers/editor.css`	121 B
`build/block-library/blocks/query-pagination/editor-rtl.css`	221 B
`build/block-library/blocks/query-pagination/editor.css`	211 B
`build/block-library/blocks/query-pagination/style-rtl.css`	282 B
`build/block-library/blocks/query-pagination/style.css`	278 B
`build/block-library/blocks/query-title/style-rtl.css`	63 B
`build/block-library/blocks/query-title/style.css`	63 B
`build/block-library/blocks/query/editor-rtl.css`	439 B
`build/block-library/blocks/query/editor.css`	439 B
`build/block-library/blocks/quote/style-rtl.css`	213 B
`build/block-library/blocks/quote/style.css`	213 B
`build/block-library/blocks/quote/theme-rtl.css`	223 B
`build/block-library/blocks/quote/theme.css`	226 B
`build/block-library/blocks/read-more/style-rtl.css`	132 B
`build/block-library/blocks/read-more/style.css`	132 B
`build/block-library/blocks/rss/editor-rtl.css`	202 B
`build/block-library/blocks/rss/editor.css`	204 B
`build/block-library/blocks/rss/style-rtl.css`	289 B
`build/block-library/blocks/rss/style.css`	288 B
`build/block-library/blocks/search/editor-rtl.css`	165 B
`build/block-library/blocks/search/editor.css`	165 B
`build/block-library/blocks/search/style-rtl.css`	409 B
`build/block-library/blocks/search/style.css`	406 B
`build/block-library/blocks/search/theme-rtl.css`	114 B
`build/block-library/blocks/search/theme.css`	114 B
`build/block-library/blocks/separator/editor-rtl.css`	146 B
`build/block-library/blocks/separator/editor.css`	146 B
`build/block-library/blocks/separator/style-rtl.css`	234 B
`build/block-library/blocks/separator/style.css`	234 B
`build/block-library/blocks/separator/theme-rtl.css`	194 B
`build/block-library/blocks/separator/theme.css`	194 B
`build/block-library/blocks/shortcode/editor-rtl.css`	464 B
`build/block-library/blocks/shortcode/editor.css`	464 B
`build/block-library/blocks/site-logo/editor-rtl.css`	488 B
`build/block-library/blocks/site-logo/editor.css`	488 B
`build/block-library/blocks/site-logo/style-rtl.css`	203 B
`build/block-library/blocks/site-logo/style.css`	203 B
`build/block-library/blocks/site-tagline/editor-rtl.css`	86 B
`build/block-library/blocks/site-tagline/editor.css`	86 B
`build/block-library/blocks/site-title/editor-rtl.css`	84 B
`build/block-library/blocks/site-title/editor.css`	84 B
`build/block-library/blocks/social-link/editor-rtl.css`	184 B
`build/block-library/blocks/social-link/editor.css`	184 B
`build/block-library/blocks/social-links/editor-rtl.css`	674 B
`build/block-library/blocks/social-links/editor.css`	673 B
`build/block-library/blocks/social-links/style-rtl.css`	1.4 kB
`build/block-library/blocks/social-links/style.css`	1.39 kB
`build/block-library/blocks/spacer/editor-rtl.css`	322 B
`build/block-library/blocks/spacer/editor.css`	322 B
`build/block-library/blocks/spacer/style-rtl.css`	48 B
`build/block-library/blocks/spacer/style.css`	48 B
`build/block-library/blocks/table/editor-rtl.css`	494 B
`build/block-library/blocks/table/editor.css`	494 B
`build/block-library/blocks/table/style-rtl.css`	611 B
`build/block-library/blocks/table/style.css`	609 B
`build/block-library/blocks/table/theme-rtl.css`	190 B
`build/block-library/blocks/table/theme.css`	190 B
`build/block-library/blocks/tag-cloud/style-rtl.css`	239 B
`build/block-library/blocks/tag-cloud/style.css`	239 B
`build/block-library/blocks/template-part/editor-rtl.css`	235 B
`build/block-library/blocks/template-part/editor.css`	235 B
`build/block-library/blocks/template-part/theme-rtl.css`	101 B
`build/block-library/blocks/template-part/theme.css`	101 B
`build/block-library/blocks/text-columns/editor-rtl.css`	95 B
`build/block-library/blocks/text-columns/editor.css`	95 B
`build/block-library/blocks/text-columns/style-rtl.css`	166 B
`build/block-library/blocks/text-columns/style.css`	166 B
`build/block-library/blocks/verse/style-rtl.css`	87 B
`build/block-library/blocks/verse/style.css`	87 B
`build/block-library/blocks/video/editor-rtl.css`	561 B
`build/block-library/blocks/video/editor.css`	563 B
`build/block-library/blocks/video/style-rtl.css`	174 B
`build/block-library/blocks/video/style.css`	174 B
`build/block-library/blocks/video/theme-rtl.css`	126 B
`build/block-library/blocks/video/theme.css`	126 B
`build/block-library/common-rtl.css`	1.02 kB
`build/block-library/common.css`	1.02 kB
`build/block-library/editor-elements-rtl.css`	75 B
`build/block-library/editor-elements.css`	75 B
`build/block-library/editor-rtl.css`	11 kB
`build/block-library/editor.css`	11 kB
`build/block-library/elements-rtl.css`	54 B
`build/block-library/elements.css`	54 B
`build/block-library/index.min.js`	189 kB
`build/block-library/reset-rtl.css`	478 B
`build/block-library/reset.css`	478 B
`build/block-library/style-rtl.css`	12.2 kB
`build/block-library/style.css`	12.2 kB
`build/block-library/theme-rtl.css`	719 B
`build/block-library/theme.css`	722 B
`build/block-serialization-default-parser/index.min.js`	1.1 kB
`build/block-serialization-spec-parser/index.min.js`	2.83 kB
`build/blocks/index.min.js`	49.6 kB
`build/components/index.min.js`	198 kB
`build/components/style-rtl.css`	11.5 kB
`build/components/style.css`	11.5 kB
`build/compose/index.min.js`	12 kB
`build/core-data/index.min.js`	15.5 kB
`build/customize-widgets/index.min.js`	11.3 kB
`build/customize-widgets/style-rtl.css`	1.38 kB
`build/customize-widgets/style.css`	1.38 kB
`build/data-controls/index.min.js`	653 B
`build/data/index.min.js`	8.06 kB
`build/date/index.min.js`	32.1 kB
`build/deprecated/index.min.js`	507 B
`build/dom-ready/index.min.js`	324 B
`build/dom/index.min.js`	4.7 kB
`build/edit-navigation/index.min.js`	16 kB
`build/edit-navigation/style-rtl.css`	3.99 kB
`build/edit-navigation/style.css`	4 kB
`build/edit-post/classic-rtl.css`	546 B
`build/edit-post/classic.css`	547 B
`build/edit-post/index.min.js`	30.7 kB
`build/edit-post/style-rtl.css`	6.94 kB
`build/edit-post/style.css`	6.94 kB
`build/edit-site/index.min.js`	58.5 kB
`build/edit-site/style-rtl.css`	8.3 kB
`build/edit-site/style.css`	8.28 kB
`build/edit-widgets/index.min.js`	16.5 kB
`build/edit-widgets/style-rtl.css`	4.34 kB
`build/edit-widgets/style.css`	4.34 kB
`build/editor/index.min.js`	41.7 kB
`build/editor/style-rtl.css`	3.66 kB
`build/editor/style.css`	3.65 kB
`build/element/index.min.js`	4.68 kB
`build/escape-html/index.min.js`	537 B
`build/format-library/index.min.js`	6.75 kB
`build/format-library/style-rtl.css`	571 B
`build/format-library/style.css`	571 B
`build/hooks/index.min.js`	1.64 kB
`build/html-entities/index.min.js`	448 B
`build/i18n/index.min.js`	3.77 kB
`build/is-shallow-equal/index.min.js`	527 B
`build/keyboard-shortcuts/index.min.js`	1.78 kB
`build/keycodes/index.min.js`	1.81 kB
`build/list-reusable-blocks/index.min.js`	1.74 kB
`build/list-reusable-blocks/style-rtl.css`	835 B
`build/list-reusable-blocks/style.css`	835 B
`build/media-utils/index.min.js`	2.93 kB
`build/notices/index.min.js`	953 B
`build/nux/index.min.js`	2.05 kB
`build/nux/style-rtl.css`	732 B
`build/nux/style.css`	728 B
`build/plugins/index.min.js`	1.94 kB
`build/preferences-persistence/index.min.js`	2.22 kB
`build/preferences/index.min.js`	1.3 kB
`build/primitives/index.min.js`	933 B
`build/priority-queue/index.min.js`	612 B
`build/react-i18n/index.min.js`	696 B
`build/react-refresh-entry/index.min.js`	8.44 kB
`build/react-refresh-runtime/index.min.js`	7.31 kB
`build/redux-routine/index.min.js`	2.74 kB
`build/reusable-blocks/index.min.js`	2.21 kB
`build/reusable-blocks/style-rtl.css`	256 B
`build/reusable-blocks/style.css`	256 B
`build/rich-text/index.min.js`	10.4 kB
`build/server-side-render/index.min.js`	1.61 kB
`build/shortcode/index.min.js`	1.53 kB
`build/token-list/index.min.js`	644 B
`build/url/index.min.js`	3.61 kB
`build/vendors/react-dom.min.js`	38.5 kB
`build/vendors/react.min.js`	4.34 kB
`build/viewport/index.min.js`	1.09 kB
`build/warning/index.min.js`	268 B
`build/widgets/index.min.js`	7.19 kB
`build/widgets/style-rtl.css`	1.18 kB
`build/widgets/style.css`	1.19 kB
`build/wordcount/index.min.js`	1.06 kB

_{compressed-size-action}

ndiego · 2022-09-14T00:34:55Z

Works like a charm, thanks for the quick fix @glendaviesnz 🙌

andrewserong

This is testing nicely for me, too.

✅ Still tests well with the generated spacing scale
✅ With provided theme.json settings, works in post editor and site editor controls.

LGTM!

…tandard 10,20,30 slugs (#44136) (cherry picked from commit 5cbfe81)

glendaviesnz · 2022-09-14T02:26:04Z

@cbravobernal I have cherry-picked this into the 14.1 release branch

priethor · 2022-09-14T11:52:49Z

cc @c4rl0sbr4v0

…tandard 10,20,30 slugs (#44136)

ockham · 2022-09-19T17:33:29Z

I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 2e2cce6

Stop checking for digit in defined values in case theme doesn't use s…

3b5a545

…tandard 10,20,30 slugs

glendaviesnz added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Sep 13, 2022

glendaviesnz requested a review from ellatrix as a code owner September 13, 2022 22:05

glendaviesnz self-assigned this Sep 13, 2022

glendaviesnz mentioned this pull request Sep 13, 2022

Spacing step controls do not aways displaying accurate information with custom steps #44133

Closed

ndiego self-requested a review September 14, 2022 00:33

ndiego approved these changes Sep 14, 2022

View reviewed changes

andrewserong approved these changes Sep 14, 2022

View reviewed changes

glendaviesnz added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Sep 14, 2022

glendaviesnz merged commit 5cbfe81 into trunk Sep 14, 2022

glendaviesnz deleted the fix/spacing-presets-unlinked-bug branch September 14, 2022 01:27

github-actions bot added this to the Gutenberg 14.2 milestone Sep 14, 2022

glendaviesnz modified the milestones: Gutenberg 14.2, Gutenberg 14.1 Sep 14, 2022

glendaviesnz added a commit that referenced this pull request Sep 14, 2022

Stop checking for digit in defined values in case theme doesn't use s…

678a40c

…tandard 10,20,30 slugs (#44136) (cherry picked from commit 5cbfe81)

ockham added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Sep 19, 2022

ockham pushed a commit that referenced this pull request Sep 19, 2022

Stop checking for digit in defined values in case theme doesn't use s…

2e2cce6

…tandard 10,20,30 slugs (#44136)

ockham removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Sep 19, 2022

aaronrobertshaw removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Oct 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spacing presets: fix bug with unlinked not applying if non int slugs used #44136

Spacing presets: fix bug with unlinked not applying if non int slugs used #44136

glendaviesnz commented Sep 13, 2022

github-actions bot commented Sep 13, 2022

ndiego commented Sep 14, 2022

andrewserong left a comment

glendaviesnz commented Sep 14, 2022

priethor commented Sep 14, 2022

ockham commented Sep 19, 2022

Spacing presets: fix bug with unlinked not applying if non int slugs used #44136

Spacing presets: fix bug with unlinked not applying if non int slugs used #44136

Conversation

glendaviesnz commented Sep 13, 2022

What?

Why?

How?

Testing Instructions

Screenshots or screencast

github-actions bot commented Sep 13, 2022

ndiego commented Sep 14, 2022

andrewserong left a comment

Choose a reason for hiding this comment

glendaviesnz commented Sep 14, 2022

priethor commented Sep 14, 2022

ockham commented Sep 19, 2022