Compose: Introduce in-house compose and pipe utils
#44112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
sgomes,
aristath,
gziolo,
swissspidy,
jorgefilipecosta,
chad1008,
ntsekouras and
fabiankaegy
tyxla
added
Mobile App - i.e. Android or iOS
|
Size Change: +112 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
chad1008
reviewed
Sep 14, 2022
There was a problem hiding this comment.
Changes look good to me, and test fine. I'll defer to more experienced eyes for an approval though 👍
I am curious about the naming. These are inspired by lodash's flow and flowRight, but we're calling them flow and compose, which kind of hides that they do the same thing in opposite directions.
Is that just because compose() was named and used all over the place already, and renaming all of those implementations to flowRight() would be more trouble than it's worth?
The naming in |
gziolo
reviewed
Sep 15, 2022
| * Composes multiple higher-order components into a single higher-order component. Performs left-to-right function | ||
| * composition, where each successive invocation is supplied the return value of the previous. | ||
| * | ||
| * This is inspired by `lodash`'s `flow` function. |
There was a problem hiding this comment.
It would be better to include the license from lodash like here:
gutenberg/packages/element/src/serialize.js
Lines 1 to 26 in a3c753d
|
From my perspective the refactor for As for |
The original goal behind naming here was to:
Essentially, yes. |
|
Thanks for the feedback, both 🙌 As suggested by @gziolo I've renamed As for the native JS pipeline operator proposal - I was also considering using it (and making sure Babel supports it), but I saw there's still no consensus on the syntax. Maybe one day we can update to it, when it finally lands in the ES world. That being said, this PR is ready for another final look. |
gziolo
added
[Type] New API
gziolo
changed the title
compose and flow utilscompose and pipe utils
tyxla
force-pushed
the
add/compose-and-flow
branch
from
26a9304
to
9aa5a36
Compare
|
I realized I needed to add a CHANGELOG entry. Added in 9aa5a36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently, we expose our own
compose()high-order composition utility, which is a re-export of_.flowRight(). This PR implements our simple in-house version ofcompose(), and uses the opportunity to also introduce an in-house version offlow(), which is the inverted version offlowRight(). That allows us to get rid of the corresponding Lodash functions in the following PRs.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're implementing a custom base
baseFlow()function and using that to generate bothcompose()andflow()so they work the same way as the Lodash versions. We're adding a few tests to ensure things work as expected.I've chosen to migrate away from the existing
_.flowRight()and_.flow()in a separate PR, to keep this one more contained.Testing Instructions
compose()is used all over the place.