Rich text: add button to clear unknown format #44086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Package] Format library
|
Size Change: +287 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
It looks like this may also fix #43680. |
|
Should this show up in the visible tools (not the show more dropdown) when the cursor is within an unknown format? |
|
@mtias Sure, if you like. |
|
Yeah, but this one seems like you might want to know if there's something odd |
|
How's this?
|
ellatrix
changed the title
ellatrix
force-pushed
the
try/rich-text-clear-unknown-formatting-button
branch
from
6dc3744
to
4e7a25f
Compare
ellatrix
force-pushed
the
try/rich-text-clear-unknown-formatting-button
branch
from
4e7a25f
to
5eda786
Compare
ellatrix
force-pushed
the
try/rich-text-clear-unknown-formatting-button
branch
from
5eda786
to
21274d5
Compare
|
Let's ship the feature, we can always iterate on it. Code is isolated to rich text and added an e2e test. |
|
I was investigating #46777 related to this PR. It appears that this PR no longer allows format types s that don't have Is there any way to address this issue? |
t-hamano
reviewed
Dec 27, 2022
| return className === null && bareElementTagName === tagName; | ||
| } ) || | ||
| formatTypes.find( ( { className, tagName } ) => { | ||
| return className === null && '*' === tagName; |
There was a problem hiding this comment.
This line ensures that core/unknown is detected.
Therefore, it appears that format types that don't have className cannot be newly registered, even if the tagName has not yet been registered.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Partly addresses #8869.
Fixes #43680.
Adds a button to remove the selected unknown formatting.
This resolves one use case for a "clear formatting" button. Note that this button will only appear when an unknown format is selected.
To select all unknown formatting, select all the text.
Maybe there's also a use case for a button to remove ALL formatting (known and unknown), but this should be done separately. We need some good heuristic for what should be removed. Should inline image be removed? Should links?
Why?
Currently there's no way to remove unknown formatting in the visual editor.
How?
Adds a catch-all format type.
Testing Instructions
Edit a paragraph with the HTML editor and wrap some text in (for example) a cite tag.
Go to the visual editor and select the formatted text.
The button to clear the unknown format should be active.
Click it to remove the formatting.
Screenshots or screencast