Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Style the "footer" in quotes to ensure backwards compatibility #4408

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Blocks: Style the "footer" in quotes to ensure backwards compatibility #4408

merged 1 commit into from
Jan 12, 2018

Conversation

youknowriad
Copy link
Contributor

Related #3851 (comment)

The quote and pullquote blocks have been updated to use cite instead of footer. To ensure old blocks still show up properly on the frontend, we bring the footer styles back in this PR.

@youknowriad youknowriad self-assigned this Jan 11, 2018
@youknowriad youknowriad requested review from mtias and gziolo January 11, 2018 14:46
gziolo
gziolo approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youknowriad youknowriad merged commit d937d3a into master Jan 12, 2018
@youknowriad youknowriad deleted the update/bc-quote-style branch January 12, 2018 09:42
@aduth aduth mentioned this pull request Jan 16, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@mtias mtias Awaiting requested review from mtias

Assignees

@youknowriad youknowriad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @gziolo