Fix center alignment on the dropdown in the categories block #44013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Block] Categories
|
I saw this PR this morning #44004. I trust your judgment on the preferred method to resolve the issue. |
carolinan
added
the
[Status] Blocked
|
I forgot that there was work being done to the markup and class names in #43666, marking as blocked for now. |
|
Size Change: +139 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
The changes to editor.scss are no longer needed.
|
@theminaldiwan I see it now, |
|
After, with Twenty Eleven: Front: Twenty Twenty-Three: Front: |
carolinan
removed
the
[Status] Blocked
|
@theminaldiwan I'm sorry it took me so long to get back to this. I would appreciate your help with testing the PR with a classic theme and a block theme. Also, I am not sure what the expected design is for the center when the block uses a list. In block themes, the bullets and text are not centered like they are in the Twenty Eleven. |
carolinan
added
the
[Priority] Low
|
Flaky tests detected in 156afef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4121198041
|
aristath
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add
text-align:centerto the block CSS so that the block can be centered when the "Display as dropdown" option is used.Fixes #43982
Why?
The center alignment was not working in the editor or the front.
How?
The markup in the editor and front is different, so CSS needed to be added to both style.scss and editor.scss.
The text alignment is limited to when the dropdown option is used, because otherwise, the text inside the list items would be centered, but not the list bullets.
Testing Instructions
Screenshots or screencast