Editor: Add 'isDeletingPost' selector #44012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
Mamaduka
requested review from
talldan,
noisysocks and
youknowriad
and removed request for
juanmaguitar,
ajitbohra,
ryanwelcher and
fabiankaegy
Mamaduka
added
[Type] Enhancement
|
Size Change: +374 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
It looks good but as a rule I'm a little wary of adding APIs that aren't used anywhere. It's best when API design is informed by real world use. Can we include a fix for #15755? |
|
@noisysocks, added in 3302c8c. Testing Instructions
ScreencastCleanShot.2022-09-12.at.10.57.03.mp4 |
alexstine
approved these changes
Sep 13, 2022
noisysocks
approved these changes
Sep 13, 2022
|
Thanks for the reviews 🙇
That would a good general Button improvement. I will push it as a follow-up. |
|
@noisysocks, the "blue" is the hover color for the button. Now I'm not sure if we want to change that. |
|
Sure but it should match the hover colour for a destructive button that doesn't have |
|
@noisysocks, the hover color is correct. The blue color is coming from the gutenberg/packages/components/src/button/style.scss Lines 184 to 186 in e5dca9d P.S. I don't mind creating a follow-up PR, but I would need help/confirmation from the design team 😅 |
|
Ah, alright then let's leave it 👍 |
30 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #43863
Fixes #15755.
PR introduces a new
isDeletingPostselector for the editor store to check if the current post is being deleted.Why?
There's a long-standing issue where users on slow networks can click the "Move to trash" button multiple times, which results in failure notices. See #15755.
To fix this, the editor needs a way to signal the components that the post is being deleted.
Initially, I tried to refactor the
trashPostaction to usedeleteEntityRecord, so we could useisDeletingEntityRecord. But some of the logic in the editor relies ongetCurrentPostto be available even when a post is trashed, anddeleteEntityRecordalso removes records from the store.A good example of this will be the
BrowserURLcomponent, which handles page redirection when the post status is changed totrash. However, there probably are more cases that I've not found yet.How?
The trash post now dispatches two new actions -
REQUEST_POST_DELETE_STARTandREQUEST_POST_DELETE_FINISH.Testing Instructions
Unit tests are passing.