Layout: unit tests for gutenberg_get_layout_style #44006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Nice one thanks for adding these in @ramonjd! Each of the tests' passed in and expected values look good to me. Just left a few suggestions to update the names of some of the tests, but otherwise LGTM! ✨
|
Thanks for testing @andrewserong !!!
Yeah, I might have rushed things a bit in the end 😄 Appreciate you picking those up. |
Co-authored-by: Andrew Serong <[email protected]>
Co-authored-by: Andrew Serong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding tests for
gutenberg_get_layout_style()Why?
To increase coverage and the chance of catching breaking changes.
Testing Instructions
npm run test:unit:php /var/www/html/wp-content/plugins/gutenberg/phpunit/block-supports/layout-test.php