Block Setttings Menu Controls: Add unstableDisplayLocation prop. #43987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
changed the title
13 tasks
|
Size Change: +2.03 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Sep 9, 2022
packages/block-editor/src/components/block-settings-menu-controls/README.md
Outdated
Show resolved
Hide resolved
scruffian
reviewed
Sep 9, 2022
packages/block-editor/src/components/block-settings-menu-controls/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Dwyer <[email protected]>
getdave
commented
Sep 9, 2022
packages/block-editor/src/components/block-settings-menu-controls/index.js
Outdated
Show resolved
Hide resolved
draganescu
reviewed
Sep 9, 2022
I think that's a fair point. Any alternative ideas come to mind? |
|
@draganescu Now renamed to |
getdave
changed the title
|
@draganescu Now |
draganescu
approved these changes
Sep 12, 2022
getdave
changed the title
cbravobernal
changed the title
|
👋 I came across this API( |
|
Whilst I can't remember the full context, I am planning to work on #42605 (of which this was a spin off PR) so it's likely needed. Happy to deprecate/remove it if I find out it's not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Spin off from/sub PR of #42605.
Adds a
contextdisplayLocationprop to the<BlockSettingsDropdown>and then on to the<BlockSettingsMenuControls>Slot.Why?
This affords the ability to contextually apply functionality inside the "3 dots" menu controls.
For example in #42605 we only wish to expose the
Renamemenu item inside the list view. ThecontextdisplayLocationprop affords this ability.How?
Adds a
contextdisplayLocationprop to the<BlockSettingsDropdown>and then on to the<BlockSettingsMenuControls>Slot.Testing Instructions
See #42605
Screenshots or screencast