Migrate Fullscreen mode test to Playwright #43963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @alvitazwar! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
skorasaurus
added
the
[Type] Automated Testing
|
@kevin940726 Can you please review this PR? |
Mamaduka
removed
the
First-time Contributor
Mamaduka
reviewed
Oct 25, 2022
There was a problem hiding this comment.
Thanks for contributing, @alvitazwar!
I left a few suggestions, which should help us make the e2e test more stable.
Co-authored-by: George Mamadashvili <[email protected]>
Co-authored-by: George Mamadashvili <[email protected]>
Co-authored-by: George Mamadashvili <[email protected]>
Co-authored-by: George Mamadashvili <[email protected]>
Co-authored-by: George Mamadashvili <[email protected]>
Co-authored-by: George Mamadashvili <[email protected]>
Mamaduka
reviewed
Oct 25, 2022
There was a problem hiding this comment.
@alvitazwar, it looks like ESLint checks are failing. Let's fix that, and I think we can merge the PR.
Mamaduka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Based on #38570, part of #38851. Migrate fullscreen-mode.test.js to its Playwright counterpart.
Why?
See #38570 for its background and rationale.
This is split into a new PR for easier review.
How?
See #38570 for the proposed migration steps.
Testing Instructions
npm run test:e2e:playwright /test/e2e/specs/editor/various/fullscreen-mode.spec.js
Screencast
Screen.Recording.2022-09-30.at.3.46.40.PM.mov