Update: Make it possible to change list items even if parent is template locked #43959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is content locked.
jorgefilipecosta
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
I'm on the fence about this one but lean towards maintaining the old behavior.
As I understand templateLock, it's about locking the "composition" (movement or block insertion/deletion), not locking content. Following that rationale this PR makes sense because the list's content is the list items, the same way the paragraph's content is the characters. It's also the old behavior and I haven't found any report of people complaining about not being lockable.
On the other hand, it's weird to me that it behaves like that. It breaks the conceptual model. Though there're two other blocks that are also unlockable (social links and navigation), so I guess that's ok.
jorgefilipecosta
deleted the
update/make-it-possible-to-add-remove-list-items-even-if-parent-is-content-locked
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous as the list block was a single block, it was possible to add and remove list items even if the list block was nested in a block with templateLock="All". Now, if a list is nested inside a block with templateLock we can not add or remove list items.
This is change that may break some blocks using inner blocks. This PR fixes the issue by using templateLock="False" on the list.
Testing Instructions
Pasted the following blocks on the code editor:
Verified I could add more list items e.g: by pressing enter (on trunk I can't).