Gallery: Display upload error notices using snackbars #43946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
requested review from
jasmussen and
glendaviesnz
and removed request for
geriux
|
Size Change: -9 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 7, 2022
glendaviesnz
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
LGTM - it would be good to convert this one to a snackbar as well, it displays as an error at top of page currently when you try and drag mixed format files into a gallery that already has images - but might be better as a separate PR as in a different block.
|
@glendaviesnz, considering that it's an image block, I would prefer a separate PR to keep an organized history 😄 |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #43767, #43890.
Update Gallery block to use snackbars for error notices. The block is already using snackbars for success notices.
Why?
#43767 (comment) - @jasmussen
How?
Testing Instructions
Screenshots or screencast