Editor: Refactor PostPublishButton tests to @testing-library/react
#43909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
Size Change: +1.92 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Rewrite is looking good!
Couple of notes:
- I noticed that the
isToggleproperty (and all of the relative branches that the component can take) don't seem to be tested - There's another test file (
label.js) that is exclusively testing for all possible label values thatPublishButtonLabelcan have — it would be great if we could simply add those assertions to the main test suite by checking but the button's accessible name (i.e.getByRole('button', {name: 'Label to test for'})), and therefore remote the separate test file.
Of course, feel free to merge this PR as-is if you'd rather focus exclusively on the RTL migration
It would be great if we could also add the expected button label for all the tests assertions — it would greatly increase the value of these tests. (eg. `getByRole('button', {name:
I see, but as you mentioned, I'm not aiming to enrich tests or get to a full test coverage here, but rather focus on the migration to RTL. This could be a good idea for someone to pick up separately though.
I think that's not necessary. These are nicely separated right now, and it only makes sense that their tests are also separated. The label ones don't even require rendering, so I think I prefer keeping them as they are.
Yeah, thanks for that - it's my personal preference as I'm focusing on getting rid of enzyme in particular.
I don't mind, although I'm not sure how valuable this will be, considering that existing tests don't seem to fully cover all cases with all the available props. Added in c25047d though. |
cbravobernal
added
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We've recently started refactoring
enzymetests to@testing-library/react.This PR refactors the
<PostPublishButton />component tests fromenzymeto@testing-library/react.Why?
@testing-library/reactprovides a better way to write tests for accessible components that is closer to the way the user experiences them.How?
We're straightforwardly replacing
enzymetests with@testing-library/reactones, usingjest-dommatchers and mocks to avoid testing unrelated implementation details.Testing Instructions
Verify tests pass:
npm run test:unit packages/editor/src/components/post-publish-button/test/index.js