RadioControl: Clean up CSS #43868
Merged
RadioControl: Clean up CSS #43868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
49 tasks
|
Size Change: -62 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
@mirka just wanted to note that this change did break styling for component users that relied on the radio control options being nested directly under the It would make more sense to add styling updates to the |
|
Hey @louwie17 , unfortunately internal DOM structure and internal classnames are not part of the public API surface of the component. We consider those as implementation details, and therefore we can't guarantee backwards compatibility on those aspects. That's why we actively discourage style overrides on the components (especially the ones relying on internal DOM structure or classnames), since they are particularly prone to breakages when the implementation details of a component change. |
|
@louwie17 Just to add: Instead, if you let us know what exactly you wanted to achieve with those style overrides, we may be able to improve the component implementation to support that kind of styling in a more robust way. |
|
@ciampo & @mirka thanks for the responses, we do indeed try to keep the overrides to a minimum where we can, and understand things could change ( as the impact of Gutenberg updates has usually caused very minimal conflicts) I do find this change a slight exception, mostly because the radio buttons have been directly nested since it's conception, and we make use of an experimental component to change that. But anyway, I guess that's just my opinion.
The only suggestion I would make then, is to allow radio control buttons to also be displayed horizontally and not only vertically. |
Exactly! I should have written that as part of my initial response, apologies! We're always open to feedback and we're happy to improve the components when possible!
That sounds reasonable! Could you open a new issue with that request, so that we can discuss the exact specs? |
7 tasks
Thanks, I created a feature request for it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38730
What?
Clean up the styles in RadioControl so it uses less custom CSS.
Note that this component already had it's margin-bottom removed internally via style overrides 😄 So there's nothing to deprecate here, just cleanup.
Why?
Less code and less overrides. This is also a necessary step to officially deprecate the bottom margin from BaseControl.
How?
__nextHasNoMarginprop on the BaseControl.Testing Instructions
npm run storybook:devand check the RadioControl story. There shouldn't be any visual changes.