Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckboxControl: Add flag to remove bottom margin #43720

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

mirka
Copy link
Member

@mirka mirka commented Aug 30, 2022

Part of #38730

What?

Adds a __nextHasNoMarginBottom prop to remove the bottom margin.

Why?

Better reusability.

How?

Passes through the prop to BaseControl.

Testing Instructions

npm run storybook:dev and see the story for CheckboxControl.

@mirka mirka added the [Package] Components /packages/components label Aug 30, 2022
@mirka mirka requested a review from ajitbohra as a code owner August 30, 2022 17:53
@mirka mirka self-assigned this Aug 30, 2022
@mirka mirka requested review from chad1008 and ciampo August 30, 2022 17:54
@mirka mirka mentioned this pull request Aug 30, 2022
49 tasks
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mirka mirka merged commit e24df61 into trunk Aug 31, 2022
@mirka mirka deleted the checkbox-margin branch August 31, 2022 18:45
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants