Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home Link: Properly close tags #43706

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Home Link: Properly close tags #43706

merged 1 commit into from
Aug 30, 2022

Conversation

Mamaduka
Copy link
Member

What?

Fixes #43705.

PR properly closes the list tag. Regression I introduced in #43024 🙈

Testing Instructions

  1. Open a Post or Page.
  2. Insert the Navigation block and add the Home Link block.
  3. Confirm the list tag is properly closed (no empty list item after the block).

Screenshots or screencast

Before
CleanShot 2022-08-30 at 17 06 56

After
CleanShot 2022-08-30 at 17 07 14

@Mamaduka Mamaduka requested a review from ajitbohra as a code owner August 30, 2022 13:10
@Mamaduka Mamaduka self-assigned this Aug 30, 2022
@Mamaduka Mamaduka added [Type] Regression Related to a regression in the latest release [Block] Home Link Affects the Home Link Block labels Aug 30, 2022
@Mamaduka Mamaduka requested review from ndiego and aristath August 30, 2022 13:11
ndiego
ndiego approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good! LGTM

image

@Mamaduka
Copy link
Member Author

@MaggieCabrera, can we cherry-pick this for 14.0? 🙇

@Mamaduka Mamaduka added the Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release label Aug 30, 2022
@Mamaduka Mamaduka merged commit c724c39 into trunk Aug 30, 2022
@Mamaduka Mamaduka deleted the fix/home-link-closing-tag branch August 30, 2022 15:51
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 30, 2022
MaggieCabrera pushed a commit that referenced this pull request Aug 31, 2022
@Mamaduka @MaggieCabrera
Home Link: Properly close tags (#43706)
9b4e75d
@priethor priethor removed the Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndiego ndiego ndiego approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@aristath aristath Awaiting requested review from aristath

Assignees

@Mamaduka Mamaduka

Labels
[Block] Home Link Affects the Home Link Block [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.

Home link: Missing closing tag
4 participants
@Mamaduka @ndiego @MaggieCabrera @priethor