Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Link: Fix background color on WhatsApp icon. #43683

Merged

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 29, 2022

Related to comment here: #42137 (comment)

What?

Fix the WhatsApp variation of the Social Link block so there is no background color when set to "Logos Only".

Why?

The background color on the WhatsApp variation of the Social Link block was not set correctly. This PR fixes that.

How?

Fix the incorrect background color specification.

Testing Instructions

  1. Add a Social Icons block
  2. Add a WhatsApp icon
  3. Switch to "Logos Only" and confirm that there is no background color.

Screenshots or screencast

Before:
image

After:
image

@ndiego ndiego added [Type] Bug An existing feature does not function as intended [Block] Social Affects the Social Block - used to display Social Media accounts labels Aug 29, 2022
@ndiego ndiego self-assigned this Aug 29, 2022
@ndiego ndiego requested a review from ajitbohra as a code owner August 29, 2022 15:28
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mamaduka Mamaduka merged commit a17a86f into WordPress:trunk Aug 31, 2022
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants