Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent single Columns blocks transforming into Columns. #43641

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Prevent single Columns blocks transforming into Columns. #43641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba95eef
Prevent single Columns blocks transforming into Columns.
ndiego Aug 26, 2022
05f568f
Change name to be more consistent.
ndiego Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/block-library/src/columns/transforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,23 @@ const transforms = {
createBlocksFromInnerBlocksTemplate( innerBlocksTemplate )
);
},
isMatch: ( { length: selectedBlocksLength } ) =>
selectedBlocksLength &&
selectedBlocksLength <= MAXIMUM_SELECTED_BLOCKS,
isMatch: ( { length: selectedBlocksLength }, blocks ) => {
// If a user is trying to transform a single Columns block, skip
// the transformation. Enabling this functiontionality creates
// nested Columns blocks resulting in an unintuitive user experience.
// Multiple Columns blocks can still be transformed.
if (
blocks.length === 1 &&
blocks[ 0 ].name === 'core/columns'
) {
return false;
}

return (
selectedBlocksLength &&
selectedBlocksLength <= MAXIMUM_SELECTED_BLOCKS
);
},
},
{
type: 'block',
Expand Down