Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow remote pattern registration in theme.json when core patterns are disabled #43634

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 26, 2022

This issue has already been fixed in Core, and will be released in 6.0.2. This PR is just to ensure parity between Core and the 6.0 compat file.

WordPress PR: WordPress/wordpress-develop#2925
Trac ticket: https://core.trac.wordpress.org/ticket/56112
Fixes: #41282

What?

Allow remote pattern registration in theme.json when core patterns are disabled in the 6.0.

Why?

Theme developers want the ability to disable core patterns yet include specific patterns from the Patterns Directory.

How?

Remove the core pattern support check.

Testing Instructions

@ndiego ndiego added [Type] Enhancement A suggestion for improvement. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Pattern Directory The Pattern Directory, a place to find patterns labels Aug 26, 2022
@ndiego ndiego requested review from Mamaduka and carolinan August 26, 2022 13:44
@ndiego ndiego self-assigned this Aug 26, 2022
@ndiego ndiego requested a review from spacedmonkey as a code owner August 26, 2022 13:44
@Mamaduka Mamaduka added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Aug 26, 2022
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ndiego ndiego merged commit 68a9ff1 into WordPress:trunk Aug 26, 2022
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Pattern Directory The Pattern Directory, a place to find patterns [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When removing core pattern, allow theme.json pattern slugs to be listed in inserter
2 participants