Guide: use code instead of keyCode for keyboard events
#43604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
ciampo
force-pushed
the
refactor/guide-keycode-to-code
branch
from
9a37c55 to
38d1f32
Compare
|
Size Change: +3 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Guidecomponent to rely oncodeinstead ofkeyCodefor keyboard eventspreventDefaultto the event callback, so that pressing arrows doesn't scroll the pageWhy?
keyCodeis deprecated, and replaced bycodeTesting Instructions
On Storybook, make sure that the
Guidecomponent: