Make more components pass type checks #43579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ciampo These components are either explicitly deprecated, or HOCs that already have hook equivalents. In other words, pretty unlikely that anyone will touch them anymore. I opted for a quick fix like this, not even converting the files to |
In the future we may decide to convert them to TypeScript in case we want to get rid of as many We could alternatively also look at marking them for removal in a future version of WordPress? |
ciampo
approved these changes
Aug 24, 2022
|
Size Change: -2 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
cbravobernal
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds some quick tweaks to make the following components pass TypeScript checks:
Why?
To get closer to having the whole components package be type checked.
Testing Instructions
✅
npm run build:package-typessucceeds