Button: Try removing hardcoded white. #43553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
CSS Styling
MaggieCabrera
approved these changes
Aug 24, 2022
|
Size Change: -112 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Inspired by #43539, this PR tries to remove the hardcoded white color present in the default button CSS.
Why?
The less hardcoded colors, the better themeability. I believe that the color used to be necessary because for the default dark gray button style, a white color was needed for contrast. But at the moment, the code appears to be unnecessary at this point (see also potentially related #21561 and #41822). It would be good to verify this further.
Testing Instructions
Please test the default button style, and the outline style, in a variety of block and classic themes, including empty theme, frontend and editor, and with hover/active/focus styles. There should be no visible change compared to trunk.
Twentyfifteen:
Empty theme:
TT2:
Twentyseventeen: