Polish placeholder radius and enable duotone on image setup state #43425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Image
|
Size Change: +19 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Aug 19, 2022
|
Testing using the Gutenberg PR build.
In the Placeholder state I clicked the duotone filter. Wondered why it did not show up. Read the instructions closer and noticed it said in the unselected state.
Thought the effect was pretty cool, and viewed it on the frontend. There I could not see the duotone filter applied. The thing is adding something to a placeholder state one might just like the effect and want to keep it that way even though it is not meant to be that way. Anyhow it is pretty nice to have this feature added even though it is pretty much a hidden feature. |
This was referenced Sep 25, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR does two things. First off, it provides a default border radius for the dashed-style placeholder that matches that of every other placeholder, 2px. But any custom radius/border set still shows:
Props to @aaronrobertshaw for foundational work!
It also enables Duotone to be visible in the setup state:
The strength of this duotone filter showing in the dashed/blurred style is something we can tweak to get the balance just right. Take it for a spin and let me know your thoughts.
Why?
It is useful for patterns to include blocks in their empty/setup states. In these placeholder states, the more of their surroundings these blocks can inherit, the better the preview of the end result.
Testing Instructions
Please test inserting an empty image block, then applying a duotone filter. It should be visible in the unselected state only.