Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP: Use str_starts_with #43410

Merged
merged 1 commit into from
Aug 19, 2022
Merged

PHP: Use str_starts_with #43410

merged 1 commit into from
Aug 19, 2022

Conversation

Soean
Copy link
Member

@Soean Soean commented Aug 19, 2022

See #43371

The str_starts_with function is available is PHP 8+. A polyfill for the function exists in WP 5.9+, so we should use that function instead of previous implementations.

@Soean Soean added the [Type] Code Quality Issues or PRs that relate to code quality label Aug 19, 2022
@Soean Soean requested a review from spacedmonkey as a code owner August 19, 2022 08:57
@Soean Soean assigned aristath and unassigned aristath Aug 19, 2022
@Soean Soean requested a review from aristath August 19, 2022 09:18
@Soean Soean merged commit a575d08 into trunk Aug 19, 2022
@Soean Soean deleted the use/str_starts_with-01 branch August 19, 2022 10:37
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Soean @aristath