Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer _x() for i18n context in core patterns #43409

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

mcsf
Copy link
Contributor

@mcsf mcsf commented Aug 19, 2022

Follows up on #43157

What?

One of the block patterns introduced in #43157, footer-with-background-color-and-three-columns.php, includes sample content made localisable using the __() function. This PR replaces those calls with _x(..., 'sample content', ...) in order to provide that context to translators.

@mcsf mcsf added Internationalization (i18n) Issues or PRs related to internationalization efforts [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Aug 19, 2022
@mcsf mcsf requested a review from ntsekouras August 19, 2022 08:53
@mcsf mcsf requested a review from spacedmonkey as a code owner August 19, 2022 08:53
@mcsf mcsf merged commit ac4d4b0 into trunk Aug 19, 2022
@mcsf mcsf deleted the update/i18n-context-in-core-block-pattern branch August 19, 2022 09:37
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants