Post Date: Add spacing support #43406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Enhancement
andrewserong
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
Size Change: +12 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Aug 22, 2022
andrewserong
deleted the
update/post-date-block-with-missing-spacing-support
branch
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Enabling spacing support for the Post Date block (hidden by default).
Why?
To create consistency across blocks. Padding and Margin can be quite useful for blocks like Post Date that are used in layouts for post templates.
How?
divelement that stretches full width, also add abox-sizing: border-boxrule for consistency with other blocks that opt-in to padding. (e.g. this ensure that the padding settings of Post Date will line up nicely with a Group block that has padding in TwentyTwentyTwo theme)Testing Instructions
Screenshots or screencast
This screengrab demonstrates the usefulness of being able to adjust a single margin side when the block is used within a Row block: