Ensure pagination numbers have an href in block edit function #43354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: +26 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Thanks for the fixing this @talldan 👍
✅ Confirmed trunk didn't add href
✅ Confirmed href addition with this PR
✅ Links appears as advertised
✅ Tested first with emptytheme, then several others.
LGTM 🚢
| Before | After |
|---|---|
 |
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
More accurately show comment pagination numbers in the block edit function by ensuring any links have an href.
Why?
When an
hrefisn't defined, the link can appear styled differently in some themes, in a way that seems like it would never happen on the frontend (each anchor would always have an href).How?
Specify an anchor href, using the same approach as the comments pagination next/before blocks. Adds an event handler that prevents clicks on these links.
Testing Instructions
Expected: pagination numbers look like visitable links
In trunk: pagination numbers don't look like visitable links
Screenshots or screencast
Before - pagination numbers don't look like visitable links
After - pagination numbers look like visitable links