Fix featured image being unselectable using arrow keys. #43323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
ellatrix
approved these changes
Aug 17, 2022
|
Thank you both for the reviews! 🙏 |
|
Size Change: -8 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
This was referenced Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on #43180, a failing test for that PR revealed a flaw in the dashed placeholder code that made it unselectable using arrow keys:
As it turns out, this is because when the block is unselected and
visibility: hidden;is applied to hide the placeholder contents until select, the placeholder shows up as empty. Which makes the writing flow not have any elements to focus inside.This PR removes that, fixing the issue:
Testing Instructions