[Block Editor]: Fix block switcher label to take into account block variations #43309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
This seems like a nice little win (I'm presuming if you have the icons option enabled, the tooltip is also correct). Possibly/probably separate from this PR, but in text-only mode, it isn't useful for the tooltip to say the same as the main label, so ideally there isn't a tooltip when the label is the same. |
|
Size Change: -1 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Aug 17, 2022
| @@ -89,6 +87,10 @@ export const BlockSwitcherDropdownMenu = ( { clientIds, blocks } ) => { | |||
| [ clientIds, blocks, blockInformation?.icon ] | |||
| ); | |||
|
|
|||
| const blockTitle = useBlockDisplayTitle( { | |||
| clientId: clientIds, | |||
There was a problem hiding this comment.
This needs to be tested with multiple blocks selected. Previously, it would use the name of the first block with:
const [ { name: firstBlockName } ] = blocks;There was a problem hiding this comment.
You're right! I'll probably just have to pick the first one..
30 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently the block switcher has a tooltip that doesn't take into account the block's block variations to display the proper title. This is also visible when we change
show button text labelsfrom preferences. This PR fixes that.Testing Instructions
Youtubeblock and hover over the block switcher icon.Youtubeinstead ofembedshow button text labelsfrom preferencesBefore
before.mov
After
after.mov