[Block Library - Query Loop]: Update posts list variation #43284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Package] Block library
ntsekouras
requested review from
mcsf,
gziolo,
jameskoster,
jasmussen and
annezazu
|
Size Change: -2 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
Sounds good to me! It's a little tricky to test, can you provide some screenshots? |
|
When I add a posts lists from the inserter, the name stays correct in the placeholder label, in the sidebar, in the options modal "Remove blockname", and in the list view. The tooltip on the block toolbar is not updated, it says query loop.
|
|
If I choose to select and insert a query loop, then the placeholder, where I choose between the presets, says "Query loop", but the sidebar and list view says posts list.
|
|
Thanks for the feedback!
Hm.. that's a separate issue and I'm looking into it now..
That's a different algorithm(before @jasmussen what's this PR essentially will do is change the name of Query Loop to Posts Lists, if the postType is What do you all think? |
|
Yes, it does seem curious for me that the name of the block changes, this has already confused me a few times in the Global Styles → Blocks, where the Query Title is duplicated under a variety of names. I understand the challenge, would appreciate Jay's thoughts as well. |
|
I think the relationship between Query Loop and its variations should be totally opaque to the user. Posts List and Query Loop should feel like totally separate blocks. So changing a Query Loop to a variation when you interact with the post type dropdown doesn't feel like the right direction to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related: #40941, #42533
Right now we have only one variation that is exposed to the inserter(Posts List) for Query Loop block. This block uses patterns and scope block variations and we face a couple of problems here:
Posts Listvariation the block cannot detect if has an active variation, changing its display name to Query Loop.This PR handles for now only the second part by adding an
isActiveprop when the postType ispost. I think differentiating variations based only theirpostTypeis enough for now, because many query attributes can change(order, orderBy, etc..) which shouldn't affect the main description of the block. Later on we need to explore how to conditionally hide/add controls declaratively and with that we should revisit theisActiveconditions.Testing instructions