Fix error in with handling spacing preset slugs #43237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int, and parse int when converting from preset var to range control value
glendaviesnz
added
the
Global Styles
|
Size Change: -38.3 kB (-3%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
Will fix the broken unit tests tomorrow. |
glendaviesnz
changed the title
andrewserong
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
The logic looks good to me here, @glendaviesnz, and good idea to treat the slugs as strings 👍
✅ Confirmed that the issue exists on trunk using string based slugs in specified spacingSizes
✅ This PR resolves the issue in both the post and site editors, and without providing the spacingSizes the spacingScales rules still work correctly (tested with steps set to 0, 7, and 10).
LGTM! ✨
andrewserong
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update theme.json spacing presets slugs to be compared as strings in the presets UI
Why?
The theme.json schema specified slugs as strings, which is a more standard format, in some places they were being compared as ints. Although the default format of 10,20,30 etc for slugs was decided on to allow for fallback to nearest values in a future iteration the slugs can be parsed to ints at that point so can be left as a string format elsewhere.
Fixes: #43234
How?
Update the generated spacingSizes slug values to be strings.
Testing Instructions
Add spacing.spacingSizes to a theme.json file with string slugs, eg:
Screenshots or screencast
Before:
After:
int-bug-after.mp4