Upgrade rtlcss to v4.0.0 #43208
Merged
Upgrade rtlcss to v4.0.0 #43208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
commented
Aug 13, 2022
Comment on lines
-42
to
-44
| :root[dir="rtl"] .editor-post-saved-state.has-text.has-icon { | ||
| justify-content: right; | ||
| } |
There was a problem hiding this comment.
This is no longer needed now that rtlcss flips the value
|
Size Change: -36 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
gziolo
requested review from
a team and
tellthemachines
and removed request for
a team
noisysocks
added
Internationalization (i18n)
ciampo
approved these changes
Oct 25, 2022
|
Thanks @ciampo! I'll rebase the PR later today and make sure the CI passes before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrading rtlcss to latest version.
Why?
Upgrading rtlcss fixes some RTL issues I spotted. See screenshots. V4 support flipping left and right in
justify-content.How?
Upgrade rtlcss to v4.0.0. Also upgrade postcss as rtlcss has a dependency on postcss ^8.4.6.
Testing Instructions
Screenshots or screencast