Rich Text: Eliminate second scan when getting text content #43207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `getTextContent()` on a `RichTextValue` we have to make sure we replace any internal-use placeholder values. Previously we've been making two string-replace passes with a new `RegExp` on each call to `getTextContext()`. In this patch we're combining the things we want to replace into a single `RegExp` pattern so that we can make both existing substitutions in one pass through the text instead of two, and we're pre-allocating that `RegExp` at module boot time so we can avoid creating new instances of it on every call.
|
Size Change: +20 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Aug 13, 2022
|
In testing I wasn't able to measure any impact, which I expected, but this should still be doing less work so it's probably worth doing. |
gziolo
added
[Package] Rich text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When calling
getTextContent()on aRichTextValuewe haveto make sure we replace any internal-use placeholder values.
Previously we've been making two string-replace passes with
a new
RegExpon each call togetTextContext().In this patch we're combining the things we want to replace
into a single
RegExppattern so that we can make bothexisting substitutions in one pass through the text instead
of two, and we're pre-allocating that
RegExpat moduleboot time so we can avoid creating new instances of it on
every call.
Why?
Why do multiple things when one thing accomplishes the same result?
Even if the performance isn't affected much (unless it's slower),
there's no need to scan the string twice.
Todo