Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullquote block: remove font definition from the default block styles #43195

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Pullquote block: remove font definition from the default block styles #43195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ac60ed
Pullquote block: remove font definition from the default block styles…
matiasbenedetto Aug 12, 2022
84e06ea
Relative unit
matiasbenedetto Aug 12, 2022
5e08afa
Pullquote: removing default css from the editor conflicting with them…
matiasbenedetto Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/block-library/src/pullquote/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@
"style": true,
"width": true
}
},
"__experimentalStyle": {
"typography": {
"fontSize": "1.5em",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify why this font size was chosen? Only because it is in between the two current values?
(I do not know why there were two font sizes in the first place)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I chose that font size because it is in the middle of the previous 2 sizes used here, with the intention of fixing the problem and causing fewer possible changes on sites using already using the block.

"lineHeight": "1.6"
}
}
},
"editorStyle": "wp-block-pullquote-editor",
Expand Down
16 changes: 0 additions & 16 deletions packages/block-library/src/pullquote/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,3 @@
.wp-block-pullquote.has-text-align-left,
.wp-block-pullquote.has-text-align-right,
.wp-block[data-align="left"] > .wp-block-pullquote,
.wp-block[data-align="right"] > .wp-block-pullquote {
& p {
font-size: 20px;
}
}

.wp-block-pullquote {
& blockquote p {
font-size: 28px;
line-height: 1.6;
}
}

// .is-style-solid-color is deprecated.
.wp-block-pullquote.is-style-solid-color {
& blockquote p {
Expand Down
9 changes: 0 additions & 9 deletions packages/block-library/src/pullquote/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,6 @@
&.alignleft,
&.alignright {
max-width: $content-width * 0.5;

p {
font-size: 1.25em;
}
}

p {
font-size: 1.75em;
line-height: 1.6;
}

cite,
Expand Down