remove comments from compiled styles #43177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -24.5 kB (-2%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
@aristath, should we close this in favor of https://core.trac.wordpress.org/ticket/56388? |
|
Sure, makes sense to commit the one in WP instead of this one. |
|
I'm reopening this one because tests are failing in the Core PR: WordPress/wordpress-develop#3095 |
|
Hi @aristath I am seeing this PR on the 6.1 project board. Does this need to be backported to 6.1, or are these Gutenberg only changed. I am a bit confused 😅 If the later, can I remove this from the 6.1 board? |
|
Hey @ndiego! |
|
Hi @aristath ! |
|
Thank you @c4rl0sbr4v0 !
This PR goes hand-in-hand with https://core.trac.wordpress.org/ticket/56388, so I'd say yes if we want to merge that PR in Core as well 👍 |
cbravobernal
added
the
Backport to WP 6.7 Beta/RC
|
Re backporting: I am not keen on changing the build setup like this so late in the cycle. I'd feel differently if it affected However, it's probably best to ask @jeffpaul @getsource and @dream-encode as the WP 6.1 tech leads. |
cbravobernal
removed
the
Backport to WP 6.7 Beta/RC
|
Let's remove the label not to be auto-included then. |
|
Following up: Decision made today to punt the corresponding Core Trac ticket. Why? See @peterwilsoncc's comments above and the explanation:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #43173